Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org.jdom version, fix for build error #1269

Closed
wants to merge 2 commits into from

Conversation

peterdewitte
Copy link
Contributor

Some people experience build errors due to lack of jdom package.

The forum post: https://forum.openremote.io/t/issue-with-building-the-main-branch/2327

Please be aware for org.jdom the following CVE issue is still open. Consider migrating to org.jdom2

https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-33813

@MartinaeyNL
Copy link
Contributor

Hi! Thanks for creating the PR! 😄

I think upgrading to jdom2 won't be an issue, and is probably a better solution.
Just mentioned it to some developers internally, so we can take a look and solve this quickly haha

@peterdewitte
Copy link
Contributor Author

Hi,

According to the forum, the issue is introduced by reposting the zwave lib with the same version number. If possible, please revert the zwave lib first. Then, create a new version for the changes in zwave.

I am working still working on a version before the merge of breaking PR #1205. My old builds are affected too.

I still need to find the time to upgrade all rules and plugins. But that is another story.

@peterdewitte
Copy link
Contributor Author

I upgraded it to jdom2, as my dev env was still open. Have fun with the PR.

@richturner
Copy link
Member

Hey thanks for the PR Peter but one of the devs who changed the zwave agent also fixed this issue in #1267

@richturner richturner closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants